drm/i915/gvt: refine ggtt range validation (5e0b3f3b) · Commits · 戴 / test

The vgpu ggtt range should be in vgpu aperture or hidden range. This patch enforce begin and end address check and guarantee both of them are in the valid range. For size=0, it will regress to vgpu_gmadr_is_valid(), will refine this usage in a later fix. Fixes: ("drm/i915/gvt: vGPU graphics memory virtualization") Reviewed-by:

Zhenyu Wang <zhenyuw@linux.intel.com> Signed-off-by:

Xiong Zhang <xiong.y.zhang@intel.com> Signed-off-by:

Zhenyu Wang <zhenyuw@linux.intel.com>

drivers/gpu/drm/i915/gvt/gtt.c

+13 −7

Original line number	Diff line number	Diff line
		@@ -53,14 +53,20 @@ static int preallocated_oos_pages = 8192;
		*/
		bool intel_gvt_ggtt_validate_range(struct intel_vgpu *vgpu, u64 addr, u32 size)
		{
		if ((!vgpu_gmadr_is_valid(vgpu, addr)) \|\| (size
		&& !vgpu_gmadr_is_valid(vgpu, addr + size - 1))) {
		gvt_vgpu_err("invalid range gmadr 0x%llx size 0x%x\n",
		if (size == 0)
		return vgpu_gmadr_is_valid(vgpu, addr);

		if (vgpu_gmadr_is_aperture(vgpu, addr) &&
		vgpu_gmadr_is_aperture(vgpu, addr + size - 1))
		return true;
		else if (vgpu_gmadr_is_hidden(vgpu, addr) &&
		vgpu_gmadr_is_hidden(vgpu, addr + size - 1))
		return true;

		gvt_dbg_mm("Invalid ggtt range at 0x%llx, size: 0x%x\n",
		addr, size);
		return false;
		}
		return true;
		}

		/* translate a guest gmadr to host gmadr */
		int intel_gvt_ggtt_gmadr_g2h(struct intel_vgpu vgpu, u64 g_addr, u64 h_addr)

Admin message