Commit a3725414 authored Jan 19, 2024 by Christopher Friedt Committed by Chris Friedt Jan 28, 2024

scripts: checkpatch.pl: fix constant comparison false positives



Comparisons that have constants on both side of the operator
were getting flagged incorrectly. Adjust the check so that
pure constant comparisons are not flagged, reducing false
positives.

WARNING:CONSTANT_COMPARISON: \
  Comparisons should place the constant on the right side of \
  the test
+BUILD_ASSERT(CONFIG_MAX_PTHREAD_COUNT == \
  CONFIG_MAX_PTHREAD_MUTEX_COUNT - 1);

Signed-off-by: Christopher Friedt <cfriedt@meta.com>

parent 248324b6

scripts/checkpatch.pl

+1 −0

Original line number	Diff line number	Diff line
		@@ -5004,6 +5004,7 @@ sub process {
		# only fix matches surrounded by parentheses to avoid incorrect
		# conversions like "FOO < baz() + 5" being "misfixed" to "baz() > FOO + 5"
		if ($perl_version_ok &&
		!($line =~ /^\+(.)($Constant\|[A-Z_][A-Z0-9_])\s($Compare)\s(.)($Constant\|[A-Z_][A-Z0-9_])(.*)/) &&
		$line =~ /^\+(.)\b($Constant\|[A-Z_][A-Z0-9_])\s($Compare)\s($LvalOrFunc)/) {
		my $lead = $1;
		my $const = $2;

Admin message