Commit 8218bf6b authored Jan 17, 2025 by Tom Hughes Committed by Benjamin Cabé Feb 11, 2025

Bluetooth: TBS: Fix -Wsometimes-uninitialized warning

Building bluetooth.shell.audio.only_gtbs with clang warns:

subsys/bluetooth/audio/tbs.c:1646:6: error: variable 'ret' is used
uninitialized whenever 'if' condition is false
[-Werror,-Wsometimes-uninitialized]
        if (param->gtbs) {
            ^~~~~~~~~~~
subsys/bluetooth/audio/tbs.c:1667:9: note: uninitialized use occurs here
        return ret;
               ^~~
subsys/bluetooth/audio/tbs.c:1646:2: note: remove the 'if' if its
condition is always true
        if (param->gtbs) {
        ^~~~~~~~~~~~~~~~~
subsys/bluetooth/audio/tbs.c:1626:9: note: initialize the variable 'ret'
to silence this warning
        int ret;
               ^
                = 0

Signed-off-by: Tom Hughes <tomhughes@chromium.org>

parent 9fca7ee3

subsys/bluetooth/audio/tbs.c

+1 −1

Changes for subsys/bluetooth/audio/tbs.c: 1 added line, 1 removed line.
Original line number	Diff line number	Diff line
		@@ -1623,7 +1623,7 @@ static bool valid_register_param(const struct bt_tbs_register_param *param)

		int bt_tbs_register_bearer(const struct bt_tbs_register_param *param)
		{
		int ret;
		int ret = -ENOEXEC;

		CHECKIF(!valid_register_param(param)) {
		LOG_DBG("Invalid parameters");

Admin message