Commit 9fca7ee3 authored by Emil Gydesen's avatar Emil Gydesen Committed by Benjamin Cabé
Browse files

Bluetooth: Controller: Fix casting in radio_aa_set for BASE0 

We have previously fixed an issue with shifting and
assigning the value without a cast, but coverity
is still complaining about aa[1] and aa[0] with:

"Casting narrower unsigned aa[1] to wider signed type
int effectively tests its lower bound."

Using the common function, sys_get_le24, should fix this issue.

Signed-off-by: default avatarEmil Gydesen <emil.gydesen@nordicsemi.no>
parent a46315fe

subsys/bluetooth/controller/ll_sw/nordic/hal/nrf5/radio/radio.c

+1 −1
Changes for subsys/bluetooth/controller/ll_sw/nordic/hal/nrf5/radio/radio.c: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -405,7 +405,7 @@ void radio_aa_set(const uint8_t *aa) 
	NRF_RADIO->RXADDRESSES =

	    ((RADIO_RXADDRESSES_ADDR0_Enabled) << RADIO_RXADDRESSES_ADDR0_Pos);

	NRF_RADIO->PREFIX0 = aa[3];

	NRF_RADIO->BASE0 = (((uint32_t) aa[2]) << 24) | (aa[1] << 16) | (aa[0] << 8);

	NRF_RADIO->BASE0 = sys_get_le24(aa) << 8;

}



void radio_pkt_configure(uint8_t bits_len, uint8_t max_len, uint8_t flags)

CRA Git | Maintained and supported by SUSTech CRA and CCSE