Commit ff87b37d authored Jul 07, 2005 by Andreas Gruenbacher Committed by Linus Torvalds Jul 07, 2005

[PATCH] ext3 xattr: Don't write to the in-inode xattr space of reserved inodes



We are not using the in-inode space for xattrs in reserved inodes because
mkfs.ext3 doesn't initialize it properly.  For those inodes, we set
i_extra_isize to 0.  Make sure that we also don't overwrite the
i_extra_isize field when writing out the inode in that case.  This is for
cleanliness only, and doesn't fix an actual bug.

Signed-off-by: Andreas Gruenbacher <agruen@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 6c036527

fs/ext3/inode.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2663,7 +2663,7 @@ static int ext3_do_update_inode(handle_t *handle,
		} else for (block = 0; block < EXT3_N_BLOCKS; block++)
		raw_inode->i_block[block] = ei->i_data[block];

		if (EXT3_INODE_SIZE(inode->i_sb) > EXT3_GOOD_OLD_INODE_SIZE)
		if (ei->i_extra_isize)
		raw_inode->i_extra_isize = cpu_to_le16(ei->i_extra_isize);

		BUFFER_TRACE(bh, "call ext3_journal_dirty_metadata");

Admin message