Commit 6c036527 authored by Christoph Lameter's avatar Christoph Lameter Committed by Linus Torvalds
Browse files

[PATCH] mostly_read data section 



Add a new section called ".data.read_mostly" for data items that are read
frequently and rarely written to like cpumaps etc.

If these maps are placed in the .data section then these frequenly read
items may end up in cachelines with data is is frequently updated.  In that
case all processors in an SMP system must needlessly reload the cachelines
again and again containing elements of those frequently used variables.

The ability to share these cachelines will allow each cpu in an SMP system
to keep local copies of those shared cachelines thereby optimizing
performance.

Signed-off-by: default avatarAlok N Kataria <alokk@calsoftinc.com>
Signed-off-by: default avatarShobhit Dayal <shobhit@calsoftinc.com>
Signed-off-by: default avatarChristoph Lameter <christoph@scalex86.org>
Signed-off-by: default avatarShai Fultheim <shai@scalex86.org>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 0db925af

arch/i386/kernel/cpu/intel.c

+1 −1
Original line number Diff line number Diff line
@@ -25,7 +25,7 @@ extern int trap_init_f00f_bug(void); 
/*

 * Alignment at which movsl is preferred for bulk memory copies.

 */

struct movsl_mask movsl_mask;

struct movsl_mask movsl_mask __read_mostly;

#endif



void __devinit early_intel_workaround(struct cpuinfo_x86 *c)

arch/i386/kernel/smpboot.c

+9 −9
Original line number Diff line number Diff line
@@ -68,21 +68,21 @@ EXPORT_SYMBOL(smp_num_siblings); 
#endif



/* Package ID of each logical CPU */

int phys_proc_id[NR_CPUS] = {[0 ... NR_CPUS-1] = BAD_APICID};

int phys_proc_id[NR_CPUS] __read_mostly = {[0 ... NR_CPUS-1] = BAD_APICID};

EXPORT_SYMBOL(phys_proc_id);



/* Core ID of each logical CPU */

int cpu_core_id[NR_CPUS] = {[0 ... NR_CPUS-1] = BAD_APICID};

int cpu_core_id[NR_CPUS] __read_mostly = {[0 ... NR_CPUS-1] = BAD_APICID};

EXPORT_SYMBOL(cpu_core_id);



cpumask_t cpu_sibling_map[NR_CPUS];

cpumask_t cpu_sibling_map[NR_CPUS] __read_mostly;

EXPORT_SYMBOL(cpu_sibling_map);



cpumask_t cpu_core_map[NR_CPUS];

cpumask_t cpu_core_map[NR_CPUS] __read_mostly;

EXPORT_SYMBOL(cpu_core_map);



/* bitmap of online cpus */

cpumask_t cpu_online_map;

cpumask_t cpu_online_map __read_mostly;

EXPORT_SYMBOL(cpu_online_map);



cpumask_t cpu_callin_map;
@@ -100,7 +100,7 @@ static int __devinitdata tsc_sync_disabled; 
struct cpuinfo_x86 cpu_data[NR_CPUS] __cacheline_aligned;

EXPORT_SYMBOL(cpu_data);



u8 x86_cpu_to_apicid[NR_CPUS] =

u8 x86_cpu_to_apicid[NR_CPUS] __read_mostly =

			{ [0 ... NR_CPUS-1] = 0xff };

EXPORT_SYMBOL(x86_cpu_to_apicid);
@@ -550,10 +550,10 @@ extern struct { 
#ifdef CONFIG_NUMA



/* which logical CPUs are on which nodes */

cpumask_t node_2_cpu_mask[MAX_NUMNODES] =

cpumask_t node_2_cpu_mask[MAX_NUMNODES] __read_mostly =

				{ [0 ... MAX_NUMNODES-1] = CPU_MASK_NONE };

/* which node each logical CPU is on */

int cpu_2_node[NR_CPUS] = { [0 ... NR_CPUS-1] = 0 };

int cpu_2_node[NR_CPUS] __read_mostly = { [0 ... NR_CPUS-1] = 0 };

EXPORT_SYMBOL(cpu_2_node);



/* set up a mapping between cpu and node. */
@@ -581,7 +581,7 @@ static inline void unmap_cpu_to_node(int cpu) 


#endif /* CONFIG_NUMA */



u8 cpu_2_logical_apicid[NR_CPUS] = { [0 ... NR_CPUS-1] = BAD_APICID };

u8 cpu_2_logical_apicid[NR_CPUS] __read_mostly = { [0 ... NR_CPUS-1] = BAD_APICID };



static void map_cpu_to_logical_apicid(void)

{

arch/i386/kernel/time.c

+1 −1
Original line number Diff line number Diff line
@@ -91,7 +91,7 @@ EXPORT_SYMBOL(rtc_lock); 
DEFINE_SPINLOCK(i8253_lock);

EXPORT_SYMBOL(i8253_lock);



struct timer_opts *cur_timer = &timer_none;

struct timer_opts *cur_timer __read_mostly = &timer_none;



/*

 * This is a special lock that is owned by the CPU and holds the index

arch/i386/kernel/timers/timer_hpet.c

+2 −2
Original line number Diff line number Diff line
@@ -18,7 +18,7 @@ 
#include "mach_timer.h"

#include <asm/hpet.h>



static unsigned long hpet_usec_quotient;	/* convert hpet clks to usec */

static unsigned long __read_mostly hpet_usec_quotient;	/* convert hpet clks to usec */

static unsigned long tsc_hpet_quotient;		/* convert tsc to hpet clks */

static unsigned long hpet_last; 	/* hpet counter value at last tick*/

static unsigned long last_tsc_low;	/* lsb 32 bits of Time Stamp Counter */
@@ -180,7 +180,7 @@ static int __init init_hpet(char* override) 
/************************************************************/



/* tsc timer_opts struct */

static struct timer_opts timer_hpet = {

static struct timer_opts timer_hpet __read_mostly = {

	.name = 		"hpet",

	.mark_offset =		mark_offset_hpet,

	.get_offset =		get_offset_hpet,

arch/i386/kernel/vmlinux.lds.S

+3 −0
Original line number Diff line number Diff line
@@ -57,6 +57,9 @@ SECTIONS 
	*(.data.cacheline_aligned)

  }



  /* rarely changed data like cpu maps */

  . = ALIGN(32);

  .data.read_mostly : AT(ADDR(.data.read_mostly) - LOAD_OFFSET) { *(.data.read_mostly) }

  _edata = .;			/* End of data section */



  . = ALIGN(THREAD_SIZE);	/* init_task */

CRA Git | Maintained and supported by SUSTech CRA and CCSE