Commit ff44d907 authored by Lorenzo Bianconi's avatar Lorenzo Bianconi Committed by Felix Fietkau
Browse files

mt76: mt7603: simplify led reg definitions 



Rely on FIELD_PREP macro for led register definitions and
remove open coding

Signed-off-by: default avatarLorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
parent d1ff4a3c

drivers/net/wireless/mediatek/mt76/mt7603/init.c

+3 −3
Original line number Diff line number Diff line
@@ -363,9 +363,9 @@ static void mt7603_led_set_config(struct mt76_dev *mt76, u8 delay_on, 
					      mt76);

	u32 val, addr;



	val = MT_LED_STATUS_DURATION(0xffff) |

	      MT_LED_STATUS_OFF(delay_off) |

	      MT_LED_STATUS_ON(delay_on);

	val = FIELD_PREP(MT_LED_STATUS_DURATION, 0xffff) |

	      FIELD_PREP(MT_LED_STATUS_OFF, delay_off) |

	      FIELD_PREP(MT_LED_STATUS_ON, delay_on);



	addr = mt7603_reg_map(dev, MT_LED_STATUS_0(mt76->led_pin));

	mt76_wr(dev, addr, val);

drivers/net/wireless/mediatek/mt76/mt7603/regs.h

+3 −12
Original line number Diff line number Diff line
@@ -585,18 +585,9 @@ enum { 


#define MT_LED_STATUS_0(_n)		MT_LED_PHYS(0x10 + ((_n) * 8))

#define MT_LED_STATUS_1(_n)		MT_LED_PHYS(0x14 + ((_n) * 8))

#define MT_LED_STATUS_OFF_MASK		GENMASK(31, 24)

#define MT_LED_STATUS_OFF(_v)		(((_v) << \

					  __ffs(MT_LED_STATUS_OFF_MASK)) & \

					 MT_LED_STATUS_OFF_MASK)

#define MT_LED_STATUS_ON_MASK		GENMASK(23, 16)

#define MT_LED_STATUS_ON(_v)		(((_v) << \

					  __ffs(MT_LED_STATUS_ON_MASK)) & \

					 MT_LED_STATUS_ON_MASK)

#define MT_LED_STATUS_DURATION_MASK	GENMASK(15, 0)

#define MT_LED_STATUS_DURATION(_v)	(((_v) << \

					  __ffs(MT_LED_STATUS_DURATION_MASK)) &\

					 MT_LED_STATUS_DURATION_MASK)

#define MT_LED_STATUS_OFF		GENMASK(31, 24)

#define MT_LED_STATUS_ON		GENMASK(23, 16)

#define MT_LED_STATUS_DURATION		GENMASK(15, 0)



#define MT_CLIENT_BASE_PHYS_ADDR	0x800c0000

CRA Git | Maintained and supported by SUSTech CRA and CCSE