Commit d1ff4a3c authored by Lorenzo Bianconi's avatar Lorenzo Bianconi Committed by Felix Fietkau
Browse files

mt76: mt76x02: simplify led reg definitions 



Rely on FIELD_PREP macro for led register definitions and
remove open coding

Signed-off-by: default avatarLorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
parent ff913979

drivers/net/wireless/mediatek/mt76/mt76x02_regs.h

+3 −9
Original line number Diff line number Diff line
@@ -235,15 +235,9 @@ 
#define MT_LED_S0(_n)			(MT_LED_S0_BASE + 8 * (_n))

#define MT_LED_S1_BASE			0x0780

#define MT_LED_S1(_n)			(MT_LED_S1_BASE + 8 * (_n))

#define MT_LED_STATUS_OFF_MASK		GENMASK(31, 24)

#define MT_LED_STATUS_OFF(_v)		(((_v) << __ffs(MT_LED_STATUS_OFF_MASK)) & \

					 MT_LED_STATUS_OFF_MASK)

#define MT_LED_STATUS_ON_MASK		GENMASK(23, 16)

#define MT_LED_STATUS_ON(_v)		(((_v) << __ffs(MT_LED_STATUS_ON_MASK)) & \

					 MT_LED_STATUS_ON_MASK)

#define MT_LED_STATUS_DURATION_MASK	GENMASK(15, 8)

#define MT_LED_STATUS_DURATION(_v)	(((_v) << __ffs(MT_LED_STATUS_DURATION_MASK)) & \

					 MT_LED_STATUS_DURATION_MASK)

#define MT_LED_STATUS_OFF		GENMASK(31, 24)

#define MT_LED_STATUS_ON		GENMASK(23, 16)

#define MT_LED_STATUS_DURATION		GENMASK(15, 8)



#define MT_FCE_PSE_CTRL			0x0800

#define MT_FCE_PARAMETERS		0x0804

drivers/net/wireless/mediatek/mt76/mt76x02_util.c

+3 −3
Original line number Diff line number Diff line
@@ -96,9 +96,9 @@ mt76x02_led_set_config(struct mt76_dev *mdev, u8 delay_on, 
					       mt76);

	u32 val;



	val = MT_LED_STATUS_DURATION(0xff) |

	      MT_LED_STATUS_OFF(delay_off) |

	      MT_LED_STATUS_ON(delay_on);

	val = FIELD_PREP(MT_LED_STATUS_DURATION, 0xff) |

	      FIELD_PREP(MT_LED_STATUS_OFF, delay_off) |

	      FIELD_PREP(MT_LED_STATUS_ON, delay_on);



	mt76_wr(dev, MT_LED_S0(mdev->led_pin), val);

	mt76_wr(dev, MT_LED_S1(mdev->led_pin), val);

CRA Git | Maintained and supported by SUSTech CRA and CCSE