Commit fe5fb42d authored Oct 16, 2018 by John Garry Committed by Martin K. Petersen Oct 16, 2018

scsi: hisi_sas: Fix spin lock management in slot_index_alloc_quirk_v2_hw()



Currently a spin_unlock_irqrestore() call is missing on the error path,
so add it.

Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent abaf75dd

drivers/scsi/hisi_sas/hisi_sas_v2_hw.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -806,8 +806,10 @@ slot_index_alloc_quirk_v2_hw(struct hisi_hba *hisi_hba,
		while (1) {
		start = find_next_zero_bit(bitmap,
		hisi_hba->slot_index_count, start);
		if (start >= end)
		if (start >= end) {
		spin_unlock_irqrestore(&hisi_hba->lock, flags);
		return -SAS_QUEUE_FULL;
		}
		/*
		* SAS IPTT bit0 should be 1, and SATA IPTT bit0 should be 0.
		*/

Admin message