Commit abaf75dd authored Oct 16, 2018 by Jens Axboe Committed by Martin K. Petersen Oct 16, 2018

scsi: sg: remove bad blk_end_request_all() call

We just need to free the request here. Additionally, this is currently
wrong for a queue that's using MQ currently, it'll crash.

Cc: Doug Gilbert <dgilbert@interlog.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Acked-by: Douglas Gilbert <dgilbert@interlog.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 8d849275

drivers/scsi/sg.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -822,7 +822,7 @@ sg_common_write(Sg_fd * sfp, Sg_request * srp,
		if (atomic_read(&sdp->detaching)) {
		if (srp->bio) {
		scsi_req_free_cmd(scsi_req(srp->rq));
		blk_end_request_all(srp->rq, BLK_STS_IOERR);
		blk_put_request(srp->rq);
		srp->rq = NULL;
		}

Admin message