Commit fde9156a authored by Chunfeng Yun's avatar Chunfeng Yun Committed by Greg Kroah-Hartman
Browse files

usb: mtu3: remove unnecessary pointer checks 



The class driver will ensure the parameters are valid
pointers before call the hook function of usb_ep_ops,
so no need check them again.

Signed-off-by: default avatarChunfeng Yun <chunfeng.yun@mediatek.com>
Link: https://lore.kernel.org/r/1595834101-13094-1-git-send-email-chunfeng.yun@mediatek.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent ec37198a

drivers/usb/mtu3/mtu3_gadget.c

+6 −19
Original line number Diff line number Diff line
@@ -263,23 +263,15 @@ void mtu3_free_request(struct usb_ep *ep, struct usb_request *req) 
static int mtu3_gadget_queue(struct usb_ep *ep,

		struct usb_request *req, gfp_t gfp_flags)

{

	struct mtu3_ep *mep;

	struct mtu3_request *mreq;

	struct mtu3 *mtu;

	struct mtu3_ep *mep = to_mtu3_ep(ep);

	struct mtu3_request *mreq = to_mtu3_request(req);

	struct mtu3 *mtu = mep->mtu;

	unsigned long flags;

	int ret = 0;



	if (!ep || !req)

		return -EINVAL;



	if (!req->buf)

		return -ENODATA;



	mep = to_mtu3_ep(ep);

	mtu = mep->mtu;

	mreq = to_mtu3_request(req);

	mreq->mtu = mtu;



	if (mreq->mep != mep)

		return -EINVAL;
@@ -303,6 +295,7 @@ static int mtu3_gadget_queue(struct usb_ep *ep, 
		return -ESHUTDOWN;

	}



	mreq->mtu = mtu;

	mreq->request.actual = 0;

	mreq->request.status = -EINPROGRESS;
@@ -335,11 +328,11 @@ static int mtu3_gadget_dequeue(struct usb_ep *ep, struct usb_request *req) 
	struct mtu3_ep *mep = to_mtu3_ep(ep);

	struct mtu3_request *mreq = to_mtu3_request(req);

	struct mtu3_request *r;

	struct mtu3 *mtu = mep->mtu;

	unsigned long flags;

	int ret = 0;

	struct mtu3 *mtu = mep->mtu;



	if (!ep || !req || mreq->mep != mep)

	if (mreq->mep != mep)

		return -EINVAL;



	dev_dbg(mtu->dev, "%s : req=%p\n", __func__, req);
@@ -379,9 +372,6 @@ static int mtu3_gadget_ep_set_halt(struct usb_ep *ep, int value) 
	unsigned long flags;

	int ret = 0;



	if (!ep)

		return -EINVAL;



	dev_dbg(mtu->dev, "%s : %s...", __func__, ep->name);



	spin_lock_irqsave(&mtu->lock, flags);
@@ -424,9 +414,6 @@ static int mtu3_gadget_ep_set_wedge(struct usb_ep *ep) 
{

	struct mtu3_ep *mep = to_mtu3_ep(ep);



	if (!ep)

		return -EINVAL;



	mep->wedged = 1;



	return usb_ep_set_halt(ep);

CRA Git | Maintained and supported by SUSTech CRA and CCSE