Commit ec37198a authored by Forest Crossman's avatar Forest Crossman Committed by Greg Kroah-Hartman
Browse files

usb: xhci: Fix ASMedia ASM1142 DMA addressing 



I've confirmed that the ASMedia ASM1142 has the same problem as the
ASM2142/ASM3142, in that it too reports that it supports 64-bit DMA
addresses when in fact it does not. As with the ASM2142/ASM3142, this
can cause problems on systems where the upper bits matter, and adding
the XHCI_NO_64BIT_SUPPORT quirk completely fixes the issue.

Acked-by: default avatarMathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: default avatarForest Crossman <cyrozap@gmail.com>
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20200728042408.180529-3-cyrozap@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1841cb25

drivers/usb/host/xhci-pci.c

+3 −1
Original line number Diff line number Diff line
@@ -59,6 +59,7 @@ 
#define PCI_DEVICE_ID_AMD_PROMONTORYA_1			0x43bc

#define PCI_DEVICE_ID_ASMEDIA_1042_XHCI			0x1042

#define PCI_DEVICE_ID_ASMEDIA_1042A_XHCI		0x1142

#define PCI_DEVICE_ID_ASMEDIA_1142_XHCI			0x1242

#define PCI_DEVICE_ID_ASMEDIA_2142_XHCI			0x2142



static const char hcd_name[] = "xhci_hcd";
@@ -268,7 +269,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci) 
		pdev->device == PCI_DEVICE_ID_ASMEDIA_1042A_XHCI)

		xhci->quirks |= XHCI_TRUST_TX_LENGTH;

	if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA &&

		pdev->device == PCI_DEVICE_ID_ASMEDIA_2142_XHCI)

	    (pdev->device == PCI_DEVICE_ID_ASMEDIA_1142_XHCI ||

	     pdev->device == PCI_DEVICE_ID_ASMEDIA_2142_XHCI))

		xhci->quirks |= XHCI_NO_64BIT_SUPPORT;



	if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA &&

CRA Git | Maintained and supported by SUSTech CRA and CCSE