Commit fb83ed49 authored Dec 10, 2018 by Cong Wang Committed by David S. Miller Dec 14, 2018

tipc: compare remote and local protocols in tipc_udp_enable()



When TIPC_NLA_UDP_REMOTE is an IPv6 mcast address but
TIPC_NLA_UDP_LOCAL is an IPv4 address, a NULL-ptr deref is triggered
as the UDP tunnel sock is initialized to IPv4 or IPv6 sock merely
based on the protocol in local address.

We should just error out when the remote address and local address
have different protocols.

Reported-by:  <syzbot+eb4da3a20fad2e52555d@syzkaller.appspotmail.com>
Cc: Ying Xue <ying.xue@windriver.com>
Cc: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Acked-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent acb4a33e

net/tipc/udp_media.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -679,6 +679,11 @@ static int tipc_udp_enable(struct net net, struct tipc_bearer b,
		if (err)
		goto err;

		if (remote.proto != local.proto) {
		err = -EINVAL;
		goto err;
		}

		/* Checking remote ip address */
		rmcast = tipc_udp_is_mcast_addr(&remote);

Admin message