Commit acb4a33e authored Dec 10, 2018 by Cong Wang Committed by David S. Miller Dec 14, 2018

tipc: fix a double kfree_skb()

tipc_udp_xmit() drops the packet on error, there is no
need to drop it again.

Fixes: ef20cd4d ("tipc: introduce UDP replicast")
Reported-and-tested-by:  <syzbot+eae585ba2cc2752d3704@syzkaller.appspotmail.com>
Cc: Ying Xue <ying.xue@windriver.com>
Cc: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 15ef70e2

net/tipc/udp_media.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -245,11 +245,9 @@ static int tipc_udp_send_msg(struct net net, struct sk_buff skb,
		}

		err = tipc_udp_xmit(net, _skb, ub, src, &rcast->addr);
		if (err) {
		kfree_skb(_skb);
		if (err)
		goto out;
		}
		}
		err = 0;
		out:
		kfree_skb(skb);

Admin message