Commit f9ad86e4 authored Feb 08, 2017 by Dan Carpenter Committed by Daniel Vetter Feb 08, 2017

drm/atomic: fix an error code in mode_fixup()



Having "ret" be a bool type works for everything except
ret = funcs->atomic_check().  The other functions all return zero on
error but ->atomic_check() returns negative error codes.  We want to
propagate the error code but instead we return 1.

I found this bug with static analysis and I don't know if it affects
run time.

Fixes: 4cd4df80 ("drm/atomic: Add ->atomic_check() to encoder helpers")
Cc: stable@vger.kernel.org
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20170207234601.GA23981@mwanda

parent 24f76b2c

drivers/gpu/drm/drm_atomic_helper.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -369,7 +369,7 @@ mode_fixup(struct drm_atomic_state *state)
		struct drm_connector *connector;
		struct drm_connector_state *conn_state;
		int i;
		bool ret;
		int ret;

		for_each_crtc_in_state(state, crtc, crtc_state, i) {
		if (!crtc_state->mode_changed &&

Admin message