Commit 24f76b2c authored by Chris Wilson's avatar Chris Wilson Committed by Daniel Vetter
Browse files

drm: Cancel drm_fb_helper_resume_work on unload



We can not allow the worker to run after its fbdev, or even the module,
has been removed.

Fixes: cfe63423 ("drm/fb-helper: Add drm_fb_helper_set_suspend_unlocked()")
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Cc: Noralf Trønnes <noralf@tronnes.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Sean Paul <seanpaul@chromium.org>
Cc: dri-devel@lists.freedesktop.org
Cc: <stable@vger.kernel.org> # v4.9+
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20170207124956.14954-2-chris@chris-wilson.co.uk
parent f21b9a92
Loading
Loading
Loading
Loading
+1 −0
Original line number Diff line number Diff line
@@ -860,6 +860,7 @@ void drm_fb_helper_fini(struct drm_fb_helper *fb_helper)
	if (!drm_fbdev_emulation)
		return;

	cancel_work_sync(&fb_helper->resume_work);
	cancel_work_sync(&fb_helper->dirty_work);

	mutex_lock(&kernel_fb_helper_lock);