mtd: rawnand: txx9ndfmc: Stop using nand_release() (f6fc7597) · Commits · 戴 / test

This helper is not very useful and very often people get confused: they use nand_release() instead of nand_cleanup(). Let's stop using nand_release() by calling mtd_device_unregister() and nand_cleanup() directly. Signed-off-by:

Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-59-miquel.raynal@bootlin.com

drivers/mtd/nand/raw/txx9ndfmc.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -371,7 +371,7 @@ static int __init txx9ndfmc_probe(struct platform_device *dev)
		static int __exit txx9ndfmc_remove(struct platform_device *dev)
		{
		struct txx9ndfmc_drvdata *drvdata = platform_get_drvdata(dev);
		int i;
		int ret, i;

		if (!drvdata)
		return 0;
		@@ -385,7 +385,9 @@ static int __exit txx9ndfmc_remove(struct platform_device *dev)
		chip = mtd_to_nand(mtd);
		txx9_priv = nand_get_controller_data(chip);

		nand_release(chip);
		ret = mtd_device_unregister(nand_to_mtd(chip));
		WARN_ON(ret);
		nand_cleanup(chip);
		kfree(txx9_priv->mtdname);
		kfree(txx9_priv);
		}

Admin message