Commit f3e169f4 authored May 19, 2020 by Miquel Raynal

mtd: rawnand: tmio: Stop using nand_release()



This helper is not very useful and very often people get confused:
they use nand_release() instead of nand_cleanup().

Let's stop using nand_release() by calling mtd_device_unregister() and
nand_cleanup() directly.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-58-miquel.raynal@bootlin.com

parent 75e9a330

drivers/mtd/nand/raw/tmio_nand.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -458,8 +458,12 @@ err_irq:
		static int tmio_remove(struct platform_device *dev)
		{
		struct tmio_nand *tmio = platform_get_drvdata(dev);
		struct nand_chip *chip = &tmio->chip;
		int ret;

		nand_release(&tmio->chip);
		ret = mtd_device_unregister(nand_to_mtd(chip));
		WARN_ON(ret);
		nand_cleanup(chip);
		tmio_hw_stop(dev, tmio);
		return 0;
		}

Admin message