Commit f6a69466 authored Dec 14, 2020 by Steven Rostedt (VMware)

tracing: Offload eval map updates to a work queue

In order for tracepoints to export their enums to user space, the use of the
TRACE_DEFINE_ENUM() macro is used. On boot up, the strings shown in the
tracefs "print fmt" lines are processed, and all the enums registered by
TRACE_DEFINE_ENUM are replaced with the interger value. This way, userspace
tools that read the raw binary data, knows how to evaluate the raw events.

This is currently done in an initcall, but it has been noticed that slow
embedded boards that have tracing may take a few seconds to process them
all, and a few seconds slow down on an embedded device is detrimental to the
system.

Instead, offload the work to a work queue and make sure that its finished by
destroying the work queue (which flushes all work) in a late initcall. This
will allow the system to continue to boot and run the updates in the
background, and this speeds up the boot time. Note, the strings being
updated are only used by user space, so finishing the process before the
system is fully booted will prevent any race issues.

Link: https://lore.kernel.org/r/68d7b3327052757d0cd6359a6c9015a85b437232.camel@pengutronix.de

Reported-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

parent adab66b7

kernel/trace/trace.c

+31 −1

Original line number	Diff line number	Diff line
		@@ -9066,7 +9066,10 @@ int tracing_init_dentry(void)
		extern struct trace_eval_map *__start_ftrace_eval_maps[];
		extern struct trace_eval_map *__stop_ftrace_eval_maps[];

		static void __init trace_eval_init(void)
		static struct workqueue_struct *eval_map_wq __initdata;
		static struct work_struct eval_map_work __initdata;

		static void __init eval_map_work_func(struct work_struct *work)
		{
		int len;

		@@ -9074,6 +9077,33 @@ static void __init trace_eval_init(void)
		trace_insert_eval_map(NULL, __start_ftrace_eval_maps, len);
		}

		static int __init trace_eval_init(void)
		{
		INIT_WORK(&eval_map_work, eval_map_work_func);

		eval_map_wq = alloc_workqueue("eval_map_wq", WQ_UNBOUND, 0);
		if (!eval_map_wq) {
		pr_err("Unable to allocate eval_map_wq\n");
		/* Do work here */
		eval_map_work_func(&eval_map_work);
		return -ENOMEM;
		}

		queue_work(eval_map_wq, &eval_map_work);
		return 0;
		}

		static int __init trace_eval_sync(void)
		{
		/* Make sure the eval map updates are finished */
		if (eval_map_wq)
		destroy_workqueue(eval_map_wq);
		return 0;
		}

		late_initcall_sync(trace_eval_sync);


		#ifdef CONFIG_MODULES
		static void trace_module_add_evals(struct module *mod)
		{

Admin message