Commit f3817e77 authored Apr 03, 2014 by Dan Carpenter Committed by Vinod Koul Apr 16, 2014

dmaengine: sirf: off by one in of_dma_sirfsoc_xlate()



The ">" here should be ">=" or we are one step beyond the end of the
sdma->channels[] array.

Fixes: 2e041c94 ('dmaengine: sirf: enable generic dt binding for dma channels')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Barry Song <Baohua.Song@csr.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

parent 2dda47d1

drivers/dma/sirf-dma.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -666,7 +666,7 @@ static struct dma_chan of_dma_sirfsoc_xlate(struct of_phandle_args dma_spec,
		struct sirfsoc_dma *sdma = ofdma->of_dma_data;
		unsigned int request = dma_spec->args[0];

		if (request > SIRFSOC_DMA_CHANNELS)
		if (request >= SIRFSOC_DMA_CHANNELS)
		return NULL;

		return dma_get_slave_channel(&sdma->channels[request].chan);

Admin message