Commit 2dda47d1 authored Apr 03, 2014 by Jean Delvare Committed by Vinod Koul Apr 16, 2014

platform: Fix timberdale dependencies



VIDEO_TIMBERDALE selects TIMB_DMA which itself depends on
MFD_TIMBERDALE, so VIDEO_TIMBERDALE should either select or depend on
MFD_TIMBERDALE as well. I chose to make it depend on it because I
think it makes more sense and it is consistent with what other options
are doing.

Adding a "|| HAS_IOMEM" to the TIMB_DMA dependencies silenced the
kconfig warning about unmet direct dependencies but it was wrong:
without MFD_TIMBERDALE, TIMB_DMA is useless as the driver has no
device to bind to.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

parent 5fc68a6c

drivers/dma/Kconfig

+1 −1

Original line number	Diff line number	Diff line
		@@ -197,7 +197,7 @@ config AMCC_PPC440SPE_ADMA

		config TIMB_DMA
		tristate "Timberdale FPGA DMA support"
		depends on MFD_TIMBERDALE \|\| HAS_IOMEM
		depends on MFD_TIMBERDALE
		select DMA_ENGINE
		help
		Enable support for the Timberdale FPGA DMA engine.

drivers/media/platform/Kconfig

+1 −1

Original line number	Diff line number	Diff line
		@@ -56,7 +56,7 @@ config VIDEO_VIU

		config VIDEO_TIMBERDALE
		tristate "Support for timberdale Video In/LogiWIN"
		depends on VIDEO_V4L2 && I2C && DMADEVICES
		depends on MFD_TIMBERDALE && VIDEO_V4L2 && I2C && DMADEVICES
		select DMA_ENGINE
		select TIMB_DMA
		select VIDEO_ADV7180

Admin message