Commit f2f8036e authored by Erik Hugne's avatar Erik Hugne Committed by David S. Miller
Browse files

tipc: add support for connect() on dgram/rdm sockets 



Following the example of ip4_datagram_connect, we store the
address in the socket structure for dgram/rdm sockets and use
that as the default destination for subsequent send() calls.
It is allowed to connect to any address types, and the behaviour
of send() will be the same as a normal sendto() with this address
provided. Binding to an AF_UNSPEC address clears the association.

Signed-off-by: default avatarErik Hugne <erik.hugne@ericsson.com>
Reviewed-by: default avatarYing Xue <ying.xue@windriver.com>
Reviewed-by: default avatarJon Maloy <jon.maloy@ericsson.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3bd88ee7

net/tipc/socket.c

+24 −14
Original line number Original line Diff line number Diff line
@@ -74,6 +74,7 @@ 
 * @link_cong: non-zero if owner must sleep because of link congestion

 * @link_cong: non-zero if owner must sleep because of link congestion

 * @sent_unacked: # messages sent by socket, and not yet acked by peer

 * @sent_unacked: # messages sent by socket, and not yet acked by peer

 * @rcv_unacked: # messages read by user, but not yet acked back to peer

 * @rcv_unacked: # messages read by user, but not yet acked back to peer

 * @remote: 'connected' peer for dgram/rdm

 * @node: hash table node

 * @node: hash table node

 * @rcu: rcu struct for tipc_sock

 * @rcu: rcu struct for tipc_sock

 */

 */
@@ -96,6 +97,7 @@ struct tipc_sock { 
	bool link_cong;

	bool link_cong;

	uint sent_unacked;

	uint sent_unacked;

	uint rcv_unacked;

	uint rcv_unacked;

	struct sockaddr_tipc remote;

	struct rhash_head node;

	struct rhash_head node;

	struct rcu_head rcu;

	struct rcu_head rcu;

};

};
@@ -854,22 +856,23 @@ static int __tipc_sendmsg(struct socket *sock, struct msghdr *m, size_t dsz) 
	u32 dnode, dport;

	u32 dnode, dport;

	struct sk_buff_head *pktchain = &sk->sk_write_queue;

	struct sk_buff_head *pktchain = &sk->sk_write_queue;

	struct sk_buff *skb;

	struct sk_buff *skb;

	struct tipc_name_seq *seq = &dest->addr.nameseq;

	struct tipc_name_seq *seq;

	struct iov_iter save;

	struct iov_iter save;

	u32 mtu;

	u32 mtu;

	long timeo;

	long timeo;

	int rc;

	int rc;





	if (unlikely(!dest))

		return -EDESTADDRREQ;



	if (unlikely((m->msg_namelen < sizeof(*dest)) ||

		     (dest->family != AF_TIPC)))

		return -EINVAL;



	if (dsz > TIPC_MAX_USER_MSG_SIZE)

	if (dsz > TIPC_MAX_USER_MSG_SIZE)

		return -EMSGSIZE;

		return -EMSGSIZE;



	if (unlikely(!dest)) {

		if (tsk->connected && sock->state == SS_READY)

			dest = &tsk->remote;

		else

			return -EDESTADDRREQ;

	} else if (unlikely(m->msg_namelen < sizeof(*dest)) ||

		   dest->family != AF_TIPC) {

		return -EINVAL;

	}

	if (unlikely(sock->state != SS_READY)) {

	if (unlikely(sock->state != SS_READY)) {

		if (sock->state == SS_LISTENING)

		if (sock->state == SS_LISTENING)

			return -EPIPE;

			return -EPIPE;
@@ -882,7 +885,7 @@ static int __tipc_sendmsg(struct socket *sock, struct msghdr *m, size_t dsz) 
			tsk->conn_instance = dest->addr.name.name.instance;

			tsk->conn_instance = dest->addr.name.name.instance;

		}

		}

	}

	}



	seq = &dest->addr.nameseq;

	timeo = sock_sndtimeo(sk, m->msg_flags & MSG_DONTWAIT);

	timeo = sock_sndtimeo(sk, m->msg_flags & MSG_DONTWAIT);





	if (dest->addrtype == TIPC_ADDR_MCAST) {

	if (dest->addrtype == TIPC_ADDR_MCAST) {
@@ -1833,17 +1836,24 @@ static int tipc_connect(struct socket *sock, struct sockaddr *dest, 
			int destlen, int flags)

			int destlen, int flags)

{

{

	struct sock *sk = sock->sk;

	struct sock *sk = sock->sk;

	struct tipc_sock *tsk = tipc_sk(sk);

	struct sockaddr_tipc *dst = (struct sockaddr_tipc *)dest;

	struct sockaddr_tipc *dst = (struct sockaddr_tipc *)dest;

	struct msghdr m = {NULL,};

	struct msghdr m = {NULL,};

	long timeout = (flags & O_NONBLOCK) ? 0 : tipc_sk(sk)->conn_timeout;

	long timeout = (flags & O_NONBLOCK) ? 0 : tsk->conn_timeout;

	socket_state previous;

	socket_state previous;

	int res;

	int res = 0;





	lock_sock(sk);

	lock_sock(sk);





	/* For now, TIPC does not allow use of connect() with DGRAM/RDM types */

	/* DGRAM/RDM connect(), just save the destaddr */

	if (sock->state == SS_READY) {

	if (sock->state == SS_READY) {

		res = -EOPNOTSUPP;

		if (dst->family == AF_UNSPEC) {

			memset(&tsk->remote, 0, sizeof(struct sockaddr_tipc));

			tsk->connected = 0;

		} else {

			memcpy(&tsk->remote, dest, destlen);

			tsk->connected = 1;

		}

		goto exit;

		goto exit;

	}

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE