Commit 3bd88ee7 authored Mar 19, 2015 by Erik Hugne Committed by David S. Miller Mar 19, 2015

tipc: do not report -EHOSTUNREACH for failed local delivery



Since commit 1186adf7 ("tipc: simplify message forwarding and
rejection in socket layer") -EHOSTUNREACH is propagated back to
the sending process if we fail to deliver the message to another
socket local to the node.
This is wrong, host unreachable should only be reported when the
destination port/name does not exist in the cluster, and that
check is always done before sending the message. Also, this
introduces inconsistent sendmsg() behavior for local/remote
destinations. Errors occurring on the receiving side should not
trickle up to the sender. If message delivery fails TIPC should
either discard the packet or reject it back to the sender based
on the destination droppable option.

Signed-off-by: Erik Hugne <erik.hugne@ericsson.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
Acked-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 18d6c584

net/tipc/link.c

+4 −2

Original line number	Original line	Diff line number	Diff line
	@@ -845,8 +845,10 @@ int tipc_link_xmit(struct net net, struct sk_buff_head list, u32 dnode,
	if (link)		if (link)
	return rc;		return rc;

	if (likely(in_own_node(net, dnode)))		if (likely(in_own_node(net, dnode))) {
	return tipc_sk_rcv(net, list);		tipc_sk_rcv(net, list);
			return 0;
			}

	__skb_queue_purge(list);		__skb_queue_purge(list);
	return rc;		return rc;

Admin message