Commit f27e1bbc authored Jul 21, 2020 by Lee Jones Committed by Martin K. Petersen Jul 24, 2020

scsi: cxgb3i: Remove bad documentation and demote kerneldoc header

Also move the header block above the correct function.

Fixes the following W=1 kernel build warning(s):

drivers/scsi/cxgbi/cxgb3i/cxgb3i.c:390: warning: Function parameter or member 'dev' not described in 'arp_failure_skb_discard'
drivers/scsi/cxgbi/cxgb3i/cxgb3i.c:390: warning: Function parameter or member 'skb' not described in 'arp_failure_skb_discard'
drivers/scsi/cxgbi/cxgb3i/cxgb3i.c:390: warning: Excess function parameter 'c3cn' description in 'arp_failure_skb_discard'
drivers/scsi/cxgbi/cxgb3i/cxgb3i.c:390: warning: Excess function parameter 'req_completion' description in 'arp_failure_skb_discard'
drivers/scsi/cxgbi/cxgb3i/cxgb3i.c:895: warning: Function parameter or member 'csk' not described in 'l2t_put'
drivers/scsi/cxgbi/cxgb3i/cxgb3i.c:895: warning: Excess function parameter 'c3cn' description in 'l2t_put'

Link: https://lore.kernel.org/r/20200721164148.2617584-41-lee.jones@linaro.org

Cc: Karen Xie <kxie@chelsio.com>
Cc: Dimitris Michailidis <dm@chelsio.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 101706dc

drivers/scsi/cxgbi/cxgb3i/cxgb3i.c

+5 −8

Original line number	Diff line number	Diff line
		@@ -375,10 +375,8 @@ static inline void make_tx_data_wr(struct cxgbi_sock csk, struct sk_buff skb,
		}
		}

		/**
		/*
		* push_tx_frames -- start transmit
		* @c3cn: the offloaded connection
		* @req_completion: request wr_ack or not
		*
		* Prepends TX_DATA_WR or CPL_CLOSE_CON_REQ headers to buffers waiting in a
		* connection's send queue and sends them on to T3. Must be called with the
		@@ -886,11 +884,6 @@ free_cpl_skbs:
		return -ENOMEM;
		}

		/**
		* release_offload_resources - release offload resource
		* @c3cn: the offloaded iscsi tcp connection.
		* Release resources held by an offload connection (TID, L2T entry, etc.)
		*/
		static void l2t_put(struct cxgbi_sock *csk)
		{
		struct t3cdev t3dev = (struct t3cdev )csk->cdev->lldev;
		@@ -902,6 +895,10 @@ static void l2t_put(struct cxgbi_sock *csk)
		}
		}

		/*
		* release_offload_resources - release offload resource
		* Release resources held by an offload connection (TID, L2T entry, etc.)
		*/
		static void release_offload_resources(struct cxgbi_sock *csk)
		{
		struct t3cdev t3dev = (struct t3cdev )csk->cdev->lldev;

Admin message