scsi: sym53c8xx_2: Ensure variable has the same stipulations as code using it (101706dc) · Commits · 戴 / test

Only declare 'tp' and 'lp' if they are going to be used. Fixes the following W=1 kernel build warning(s): drivers/scsi/sym53c8xx_2/sym_hipd.c: In function ‘sym_complete_error’: drivers/scsi/sym53c8xx_2/sym_hipd.c:5356:18: warning: variable ‘lp’ set but not used [-Wunused-but-set-variable] drivers/scsi/sym53c8xx_2/sym_hipd.c: In function ‘sym_complete_ok’: drivers/scsi/sym53c8xx_2/sym_hipd.c:5485:18: warning: variable ‘lp’ set but not used [-Wunused-but-set-variable] Link: https://lore.kernel.org/r/20200721164148.2617584-39-lee.jones@linaro.org Cc: Matthew Wilcox <willy@infradead.org> Cc: Gerard Roudier <groudier@free.fr> Cc: Wolfgang Stanglmeier <wolf@cologne.de> Cc: Stefan Esser <se@mi.Uni-Koeln.de> Cc: Richard Waltham <dormouse@farsrobt.demon.co.uk> Signed-off-by:

Lee Jones <lee.jones@linaro.org> Signed-off-by:

Martin K. Petersen <martin.petersen@oracle.com>

drivers/scsi/sym53c8xx_2/sym_hipd.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -5352,8 +5352,10 @@ void sym_complete_error(struct sym_hcb np, struct sym_ccb cp)
		{
		struct scsi_device *sdev;
		struct scsi_cmnd *cmd;
		#ifdef SYM_OPT_HANDLE_DEVICE_QUEUEING
		struct sym_tcb *tp;
		struct sym_lcb *lp;
		#endif
		int resid;
		int i;

		@@ -5370,11 +5372,13 @@ void sym_complete_error(struct sym_hcb np, struct sym_ccb cp)
		cp->host_status, cp->ssss_status, cp->host_flags);
		}

		#ifdef SYM_OPT_HANDLE_DEVICE_QUEUEING
		/*
		* Get target and lun pointers.
		*/
		tp = &np->target[cp->target];
		lp = sym_lp(tp, sdev->lun);
		#endif

		/*
		* Check for extended errors.
		@@ -5481,8 +5485,10 @@ finish:
		*/
		void sym_complete_ok (struct sym_hcb np, struct sym_ccb cp)
		{
		#ifdef SYM_OPT_HANDLE_DEVICE_QUEUEING
		struct sym_tcb *tp;
		struct sym_lcb *lp;
		#endif
		struct scsi_cmnd *cmd;
		int resid;

		@@ -5498,11 +5504,13 @@ void sym_complete_ok (struct sym_hcb np, struct sym_ccb cp)
		*/
		cmd = cp->cmd;

		#ifdef SYM_OPT_HANDLE_DEVICE_QUEUEING
		/*
		* Get target and lun pointers.
		*/
		tp = &np->target[cp->target];
		lp = sym_lp(tp, cp->lun);
		#endif

		/*
		* If all data have been transferred, given than no

Admin message