Commit f10bb940 authored by Evan Quan's avatar Evan Quan Committed by Alex Deucher
Browse files

drm/amd/powerplay: optimize the interface for mgpu fan boost enablement 



Cover the implementation details from outside(of power). Also preparing
for expanding this to swSMU.

Signed-off-by: default avatarEvan Quan <evan.quan@amd.com>
Acked-by: default avatarNirmoy Das <nirmoy.das@amd.com>
Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent e1a84641

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

+1 −3
Original line number Diff line number Diff line
@@ -2228,9 +2228,7 @@ static int amdgpu_device_enable_mgpu_fan_boost(void) 
		gpu_ins = &(mgpu_info.gpu_ins[i]);

		adev = gpu_ins->adev;

		if (!(adev->flags & AMD_IS_APU) &&

		    !gpu_ins->mgpu_fan_enabled &&

		    adev->powerplay.pp_funcs &&

		    adev->powerplay.pp_funcs->enable_mgpu_fan_boost) {

		    !gpu_ins->mgpu_fan_enabled) {

			ret = amdgpu_dpm_enable_mgpu_fan_boost(adev);

			if (ret)

				break;

drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c

+13 −0
Original line number Diff line number Diff line
@@ -1216,3 +1216,16 @@ int amdgpu_dpm_allow_xgmi_power_down(struct amdgpu_device *adev, bool en) 


	return 0;

}



int amdgpu_dpm_enable_mgpu_fan_boost(struct amdgpu_device *adev)

{

	void *pp_handle = adev->powerplay.pp_handle;

	const struct amd_pm_funcs *pp_funcs =

			adev->powerplay.pp_funcs;

	int ret = 0;



	if (pp_funcs && pp_funcs->enable_mgpu_fan_boost)

		ret = pp_funcs->enable_mgpu_fan_boost(pp_handle);



	return ret;

}

drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h

+2 −4
Original line number Diff line number Diff line
@@ -357,10 +357,6 @@ enum amdgpu_pcie_gen { 
		((adev)->powerplay.pp_funcs->odn_edit_dpm_table(\

			(adev)->powerplay.pp_handle, type, parameter, size))



#define amdgpu_dpm_enable_mgpu_fan_boost(adev) \

		((adev)->powerplay.pp_funcs->enable_mgpu_fan_boost(\

			(adev)->powerplay.pp_handle))



#define amdgpu_dpm_get_ppfeature_status(adev, buf) \

		((adev)->powerplay.pp_funcs->get_ppfeature_status(\

			(adev)->powerplay.pp_handle, (buf)))
@@ -548,4 +544,6 @@ int amdgpu_dpm_set_df_cstate(struct amdgpu_device *adev, 


int amdgpu_dpm_allow_xgmi_power_down(struct amdgpu_device *adev, bool en);



int amdgpu_dpm_enable_mgpu_fan_boost(struct amdgpu_device *adev);



#endif

CRA Git | Maintained and supported by SUSTech CRA and CCSE