Commit e1a84641 authored Aug 06, 2020 by Kevin Wang Committed by Alex Deucher Aug 14, 2020

drm/amdgpu: fix uninit-value in arcturus_log_thermal_throttling_event()

when function arcturus_get_smu_metrics_data() call failed,
it will cause the variable "throttler_status" isn't initialized before use.

warning:
powerplay/arcturus_ppt.c:2268:24: warning: ‘throttler_status’ may be used uninitialized in this function [-Wmaybe-uninitialized]
2268 | if (throttler_status & logging_label[throttler_idx].feature_mask) {

Signed-off-by: Kevin Wang <kevin1.wang@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent ba4e049e

drivers/gpu/drm/amd/powerplay/arcturus_ppt.c

+6 −3

Original line number	Diff line number	Diff line
		@@ -2208,14 +2208,17 @@ static const struct throttling_logging_label {
		};
		static void arcturus_log_thermal_throttling_event(struct smu_context *smu)
		{
		int ret;
		int throttler_idx, throtting_events = 0, buf_idx = 0;
		struct amdgpu_device *adev = smu->adev;
		uint32_t throttler_status;
		char log_buf[256];

		arcturus_get_smu_metrics_data(smu,
		ret = arcturus_get_smu_metrics_data(smu,
		METRICS_THROTTLER_STATUS,
		&throttler_status);
		if (ret)
		return;

		memset(log_buf, 0, sizeof(log_buf));
		for (throttler_idx = 0; throttler_idx < ARRAY_SIZE(logging_label);

Admin message