Commit f081042d authored Dec 22, 2019 by Hangbin Liu Committed by David S. Miller Dec 24, 2019

net/dst: do not confirm neighbor for vxlan and geneve pmtu update



When do IPv6 tunnel PMTU update and calls __ip6_rt_update_pmtu() in the end,
we should not call dst_confirm_neigh() as there is no two-way communication.

So disable the neigh confirm for vxlan and geneve pmtu update.

v5: No change.
v4: No change.
v3: Do not remove dst_confirm_neigh, but add a new bool parameter in
    dst_ops.update_pmtu to control whether we should do neighbor confirm.
    Also split the big patch to small ones for each area.
v2: Remove dst_confirm_neigh in __ip6_rt_update_pmtu.

Fixes: a93bf0ff ("vxlan: update skb dst pmtu on tx path")
Fixes: 52a589d5 ("geneve: update skb dst pmtu on tx path")
Reviewed-by: Guillaume Nault <gnault@redhat.com>
Tested-by: Guillaume Nault <gnault@redhat.com>
Acked-by: David Ahern <dsahern@gmail.com>
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 4d42df46

include/net/dst.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -535,7 +535,7 @@ static inline void skb_tunnel_check_pmtu(struct sk_buff *skb,
		u32 encap_mtu = dst_mtu(encap_dst);

		if (skb->len > encap_mtu - headroom)
		skb_dst_update_pmtu(skb, encap_mtu - headroom);
		skb_dst_update_pmtu_no_confirm(skb, encap_mtu - headroom);
		}

		#endif /* _NET_DST_H */

Admin message