Commit 4d42df46 authored Dec 22, 2019 by Hangbin Liu Committed by David S. Miller Dec 24, 2019

sit: do not confirm neighbor when do pmtu update



When do IPv6 tunnel PMTU update and calls __ip6_rt_update_pmtu() in the end,
we should not call dst_confirm_neigh() as there is no two-way communication.

v5: No change.
v4: No change.
v3: Do not remove dst_confirm_neigh, but add a new bool parameter in
    dst_ops.update_pmtu to control whether we should do neighbor confirm.
    Also split the big patch to small ones for each area.
v2: Remove dst_confirm_neigh in __ip6_rt_update_pmtu.

Reviewed-by: Guillaume Nault <gnault@redhat.com>
Acked-by: David Ahern <dsahern@gmail.com>
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 8247a79e

net/ipv6/sit.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -944,7 +944,7 @@ static netdev_tx_t ipip6_tunnel_xmit(struct sk_buff *skb,
		}

		if (tunnel->parms.iph.daddr)
		skb_dst_update_pmtu(skb, mtu);
		skb_dst_update_pmtu_no_confirm(skb, mtu);

		if (skb->len > mtu && !skb_is_gso(skb)) {
		icmpv6_send(skb, ICMPV6_PKT_TOOBIG, 0, mtu);

Admin message