drm/i915: inline skl_copy_ddb_for_pipe() to its only caller (f00ca815) · Commits · 戴 / test

While things may have been different before, right now the function is very simple and has a single caller. IMHO any possible benefits from an abstraction here are gone and not worth the price of the current indirection while reading the code. Cc: Mahesh Kumar <mahesh1.kumar@intel.com> Reviewed-by:

Mahesh Kumar <mahesh1.kumar@intel.com> Signed-off-by:

Paulo Zanoni <paulo.r.zanoni@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20180607230700.28359-1-paulo.r.zanoni@intel.com

drivers/gpu/drm/i915/intel_pm.c

+4 −12

Original line number	Diff line number	Diff line
		@@ -5141,17 +5141,6 @@ skl_compute_ddb(struct drm_atomic_state *state)
		return 0;
		}

		static void
		skl_copy_ddb_for_pipe(struct skl_ddb_values *dst,
		struct skl_ddb_values *src,
		enum pipe pipe)
		{
		memcpy(dst->ddb.uv_plane[pipe], src->ddb.uv_plane[pipe],
		sizeof(dst->ddb.uv_plane[pipe]));
		memcpy(dst->ddb.plane[pipe], src->ddb.plane[pipe],
		sizeof(dst->ddb.plane[pipe]));
		}

		static void
		skl_print_wm_changes(const struct drm_atomic_state *state)
		{
		@@ -5381,7 +5370,10 @@ static void skl_initial_wm(struct intel_atomic_state *state,
		if (cstate->base.active_changed)
		skl_atomic_update_crtc_wm(state, cstate);

		skl_copy_ddb_for_pipe(hw_vals, results, pipe);
		memcpy(hw_vals->ddb.uv_plane[pipe], results->ddb.uv_plane[pipe],
		sizeof(hw_vals->ddb.uv_plane[pipe]));
		memcpy(hw_vals->ddb.plane[pipe], results->ddb.plane[pipe],
		sizeof(hw_vals->ddb.plane[pipe]));

		mutex_unlock(&dev_priv->wm.wm_mutex);
		}

Admin message