tg3: Restrict phy ioctl access (ed199fac) · Commits · 戴 / test

If management firmware is present and the device is down, the firmware will assume control of the phy. If a phy access were allowed from the host, it will collide with firmware phy accesses, resulting in unpredictable behavior. This patch fixes the problem by disallowing phy accesses during the problematic condition. Signed-off-by:

Matt Carlson <mcarlson@broadcom.com> Reviewed-by:

Michael Chan <mchan@broadcom.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/tg3.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -11158,7 +11158,9 @@ static int tg3_ioctl(struct net_device dev, struct ifreq ifr, int cmd)
		if (tp->phy_flags & TG3_PHYFLG_PHY_SERDES)
		break; /* We have no PHY */

		if (tp->phy_flags & TG3_PHYFLG_IS_LOW_POWER)
		if ((tp->phy_flags & TG3_PHYFLG_IS_LOW_POWER) \|\|
		((tp->tg3_flags & TG3_FLAG_ENABLE_ASF) &&
		!netif_running(dev)))
		return -EAGAIN;

		spin_lock_bh(&tp->lock);
		@@ -11174,7 +11176,9 @@ static int tg3_ioctl(struct net_device dev, struct ifreq ifr, int cmd)
		if (tp->phy_flags & TG3_PHYFLG_PHY_SERDES)
		break; /* We have no PHY */

		if (tp->phy_flags & TG3_PHYFLG_IS_LOW_POWER)
		if ((tp->phy_flags & TG3_PHYFLG_IS_LOW_POWER) \|\|
		((tp->tg3_flags & TG3_FLAG_ENABLE_ASF) &&
		!netif_running(dev)))
		return -EAGAIN;

		spin_lock_bh(&tp->lock);

Admin message