Commit 0d672e9f authored Feb 15, 2011 by Ivan Vecera Committed by David S. Miller Feb 17, 2011

drivers/net: Call netif_carrier_off at the end of the probe



Without calling of netif_carrier_off at the end of the probe the operstate
is unknown when the device is initially opened. By default the carrier is
on so when the device is opened and netif_carrier_on is called the link
watch event is not fired and operstate remains zero (unknown).

This patch fixes this behavior in forcedeth and r8169.

Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Acked-by: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent c600636b

drivers/net/forcedeth.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -5645,6 +5645,8 @@ static int __devinit nv_probe(struct pci_dev *pci_dev, const struct pci_device_i
		goto out_error;
		}

		netif_carrier_off(dev);

		dev_info(&pci_dev->dev, "ifname %s, PHY OUI 0x%x @ %d, addr %pM\n",
		dev->name, np->phy_oui, np->phyaddr, dev->dev_addr);

drivers/net/r8169.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -3190,6 +3190,8 @@ rtl8169_init_one(struct pci_dev pdev, const struct pci_device_id ent)
		if (pci_dev_run_wake(pdev))
		pm_runtime_put_noidle(&pdev->dev);

		netif_carrier_off(dev);

		out:
		return rc;

Admin message