scsi: lpfc: Fix crash on powering off BFS VM with passthrough device (ecbb227e) · Commits · 戴 / test

Null pointer dereference when BFS VM is powered off The driver incorrectly uses sli3_ring on SLI-4 adapters Use the correct ring structure based on sli_rev Signed-off-by:

Dick Kennedy <dick.kennedy@broadcom.com> Signed-off-by:

James Smart <james.smart@broadcom.com> Tested-by:

Raphael Silva <raphasil@linux.vnet.ibm.com> Signed-off-by:

Martin K. Petersen <martin.petersen@oracle.com>

drivers/scsi/lpfc/lpfc_sli.c

+10 −2

Original line number	Diff line number	Diff line
		@@ -10951,6 +10951,7 @@ lpfc_sli_abort_iocb(struct lpfc_vport vport, struct lpfc_sli_ring pring,
		struct lpfc_hba *phba = vport->phba;
		struct lpfc_iocbq *iocbq;
		struct lpfc_iocbq *abtsiocb;
		struct lpfc_sli_ring *pring_s4;
		IOCB_t *cmd = NULL;
		int errcnt = 0, ret_val = 0;
		int i;
		@@ -11004,6 +11005,13 @@ lpfc_sli_abort_iocb(struct lpfc_vport vport, struct lpfc_sli_ring pring,

		/* Setup callback routine and issue the command. */
		abtsiocb->iocb_cmpl = lpfc_sli_abort_fcp_cmpl;
		if (phba->sli_rev == LPFC_SLI_REV4) {
		pring_s4 = lpfc_sli4_calc_ring(phba, iocbq);
		if (!pring_s4)
		continue;
		ret_val = lpfc_sli_issue_iocb(phba, pring_s4->ringno,
		abtsiocb, 0);
		} else
		ret_val = lpfc_sli_issue_iocb(phba, pring->ringno,
		abtsiocb, 0);
		if (ret_val == IOCB_ERROR) {

Admin message