Commit 522dceeb authored Jun 01, 2017 by James Smart Committed by Martin K. Petersen Jun 12, 2017

scsi: lpfc: Fix return value of board_mode store routine in case of online failure



On hbacmd reset failure, observing wrong string "nline" in kernel log.

On failure, non negative value (1) is returned from sysfs store
routine. It is interpreted as count by kernel and store routine is
called again with the remaining characters as input.

Fix: Return negative error code (-EIO) in case of failure.

Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 2cee7808

drivers/scsi/lpfc/lpfc_attr.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1351,6 +1351,8 @@ lpfc_board_mode_store(struct device dev, struct device_attribute attr,
		goto board_mode_out;
		}
		wait_for_completion(&online_compl);
		if (status)
		status = -EIO;
		} else if (strncmp(buf, "offline", sizeof("offline") - 1) == 0)
		status = lpfc_do_offline(phba, LPFC_EVT_OFFLINE);
		else if (strncmp(buf, "warm", sizeof("warm") - 1) == 0)

Admin message