Commit ea013a9b authored by Andreas Werner's avatar Andreas Werner Committed by Tejun Heo
Browse files

libata-eh.c: Introduce new ata port flag for controller which lockup on read log page 



Some controller lockup on a ata_read_log_page.
Add new ata port flag ATA_FLAG_NO_LOG_PAGE which can used
to blacklist a controller.

If this flag is set, any attempt to read a log page returns an error
without actually issuing the command.

Signed-off-by: default avatarAndreas Werner <andreas.werner@men.de>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent d98f1cd0

drivers/ata/libata-eh.c

+8 −0
Original line number Diff line number Diff line
@@ -1505,12 +1505,20 @@ static const char *ata_err_string(unsigned int err_mask) 
unsigned int ata_read_log_page(struct ata_device *dev, u8 log,

			       u8 page, void *buf, unsigned int sectors)

{

	unsigned long ap_flags = dev->link->ap->flags;

	struct ata_taskfile tf;

	unsigned int err_mask;

	bool dma = false;



	DPRINTK("read log page - log 0x%x, page 0x%x\n", log, page);



	/*

	 * Return error without actually issuing the command on controllers

	 * which e.g. lockup on a read log page.

	 */

	if (ap_flags & ATA_FLAG_NO_LOG_PAGE)

		return AC_ERR_DEV;



retry:

	ata_tf_init(dev, &tf);

	if (dev->dma_mode && ata_id_has_read_log_dma_ext(dev->id) &&

include/linux/libata.h

+1 −0
Original line number Diff line number Diff line
@@ -210,6 +210,7 @@ enum { 
	ATA_FLAG_SLAVE_POSS	= (1 << 0), /* host supports slave dev */

					    /* (doesn't imply presence) */

	ATA_FLAG_SATA		= (1 << 1),

	ATA_FLAG_NO_LOG_PAGE	= (1 << 5), /* do not issue log page read */

	ATA_FLAG_NO_ATAPI	= (1 << 6), /* No ATAPI support */

	ATA_FLAG_PIO_DMA	= (1 << 7), /* PIO cmds via DMA */

	ATA_FLAG_PIO_LBA48	= (1 << 8), /* Host DMA engine is LBA28 only */

CRA Git | Maintained and supported by SUSTech CRA and CCSE