Commit d98f1cd0 authored Nov 26, 2015 by Mikulas Patocka Committed by Tejun Heo Nov 30, 2015

sata_sil: disable trim

When I connect an Intel SSD to SATA SIL controller (PCI ID 1095:3114), any
TRIM command results in I/O errors being reported in the log. There is
other similar error reported with TRIM and the SIL controller:
https://bugs.centos.org/view.php?id=5880



Apparently the controller doesn't support TRIM commands. This patch
disables TRIM support on the SATA SIL controller.

ata7.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x0
ata7.00: BMDMA2 stat 0x50001
ata7.00: failed command: DATA SET MANAGEMENT
ata7.00: cmd 06/01:01:00:00:00/00:00:00:00:00/a0 tag 0 dma 512 out
         res 51/04:01:00:00:00/00:00:00:00:00/a0 Emask 0x1 (device error)
ata7.00: status: { DRDY ERR }
ata7.00: error: { ABRT }
ata7.00: device reported invalid CHS sector 0
sd 8:0:0:0: [sdb] tag#0 FAILED Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE
sd 8:0:0:0: [sdb] tag#0 Sense Key : Illegal Request [current] [descriptor]
sd 8:0:0:0: [sdb] tag#0 Add. Sense: Unaligned write command
sd 8:0:0:0: [sdb] tag#0 CDB: Write same(16) 93 08 00 00 00 00 00 21 95 88 00 20 00 00 00 00
blk_update_request: I/O error, dev sdb, sector 2200968

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Cc: stable@kernel.org
Signed-off-by: Tejun Heo <tj@kernel.org>

parent 023113d2

drivers/ata/sata_sil.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -630,6 +630,9 @@ static void sil_dev_config(struct ata_device *dev)
		unsigned int n, quirks = 0;
		unsigned char model_num[ATA_ID_PROD_LEN + 1];

		/* This controller doesn't support trim */
		dev->horkage \|= ATA_HORKAGE_NOTRIM;

		ata_id_c_string(dev->id, model_num, ATA_ID_PROD, sizeof(model_num));

		for (n = 0; sil_blacklist[n].product; n++)

Admin message