Commit 023113d2 authored Nov 26, 2015 by Xiangliang Yu Committed by Tejun Heo Nov 30, 2015

AHCI: Fix softreset failed issue of Port Multiplier



Current code doesn't update port value of Port Multiplier(PM) when
sending FIS of softreset to device, command will fail if FBS is
enabled.

There are two ways to fix the issue: the first is to disable FBS
before sending softreset command to PM device and the second is
to update port value of PM when sending command.

For the first way, i can't find any related rule in AHCI Spec. The
second way can avoid disabling FBS and has better performance.

Signed-off-by: Xiangliang Yu <Xiangliang.Yu@amd.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: stable@vger.kernel.org

parent 4f1dd973

drivers/ata/libahci.c

+9 −0

Original line number	Diff line number	Diff line
		@@ -1273,6 +1273,15 @@ static int ahci_exec_polled_cmd(struct ata_port *ap, int pmp,
		ata_tf_to_fis(tf, pmp, is_cmd, fis);
		ahci_fill_cmd_slot(pp, 0, cmd_fis_len \| flags \| (pmp << 12));

		/* set port value for softreset of Port Multiplier */
		if (pp->fbs_enabled && pp->fbs_last_dev != pmp) {
		tmp = readl(port_mmio + PORT_FBS);
		tmp &= ~(PORT_FBS_DEV_MASK \| PORT_FBS_DEC);
		tmp \|= pmp << PORT_FBS_DEV_OFFSET;
		writel(tmp, port_mmio + PORT_FBS);
		pp->fbs_last_dev = pmp;
		}

		/* issue & wait */
		writel(1, port_mmio + PORT_CMD_ISSUE);

Admin message