Commit e787f193 authored Jul 31, 2019 by Wang Xiayang Committed by Marc Kleine-Budde Aug 02, 2019

can: peak_usb: force the string buffer NULL-terminated



strncpy() does not ensure NULL-termination when the input string size
equals to the destination buffer size IFNAMSIZ. The output string is
passed to dev_info() which relies on the NULL-termination.

Use strlcpy() instead.

This issue is identified by a Coccinelle script.

Signed-off-by: Wang Xiayang <xywang.sjtu@sjtu.edu.cn>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

parent cd28aa2e

drivers/net/can/usb/peak_usb/pcan_usb_core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -855,7 +855,7 @@ static void peak_usb_disconnect(struct usb_interface *intf)

		dev_prev_siblings = dev->prev_siblings;
		dev->state &= ~PCAN_USB_STATE_CONNECTED;
		strncpy(name, netdev->name, IFNAMSIZ);
		strlcpy(name, netdev->name, IFNAMSIZ);

		unregister_netdev(netdev);

Admin message