Commit cd28aa2e authored Jul 31, 2019 by Wang Xiayang Committed by Marc Kleine-Budde Aug 02, 2019

can: sja1000: force the string buffer NULL-terminated



strncpy() does not ensure NULL-termination when the input string size
equals to the destination buffer size IFNAMSIZ. The output string
'name' is passed to dev_info which relies on NULL-termination.

Use strlcpy() instead.

This issue is identified by a Coccinelle script.

Signed-off-by: Wang Xiayang <xywang.sjtu@sjtu.edu.cn>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

parent 224c0497

drivers/net/can/sja1000/peak_pcmcia.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -479,7 +479,7 @@ static void pcan_free_channels(struct pcan_pccard *card)
		if (!netdev)
		continue;

		strncpy(name, netdev->name, IFNAMSIZ);
		strlcpy(name, netdev->name, IFNAMSIZ);

		unregister_sja1000dev(netdev);

Admin message