Commit 224c0497 authored Jul 30, 2019 by Denis Kirjanov Committed by David S. Miller Aug 01, 2019

net: usb: pegasus: fix improper read if get_registers() fail



get_registers() may fail with -ENOMEM and in this
case we can read a garbage from the status variable tmp.

Reported-by:  <syzbot+3499a83b2d062ae409d4@syzkaller.appspotmail.com>
Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 4da5f001

drivers/net/usb/pegasus.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -282,7 +282,7 @@ static void mdio_write(struct net_device *dev, int phy_id, int loc, int val)
		static int read_eprom_word(pegasus_t pegasus, __u8 index, __u16 retdata)
		{
		int i;
		__u8 tmp;
		__u8 tmp = 0;
		__le16 retdatai;
		int ret;

Admin message