Commit e76d3d60 authored Aug 13, 2019 by Ioana Ciornei Committed by Greg Kroah-Hartman Aug 14, 2019

staging: fsl-dpaa2/ethsw: remove redundant VLAN check

The ethsw_add_vlan() function is already called only when the VLAN is
not yet configured on the switch. Remove the redundant check.

Reported-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Link: https://lore.kernel.org/r/1565700187-16048-8-git-send-email-ioana.ciornei@nxp.com

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 36ec62b7

drivers/staging/fsl-dpaa2/ethsw/ethsw.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -34,11 +34,6 @@ static int ethsw_add_vlan(struct ethsw_core *ethsw, u16 vid)
		.fdb_id = 0,
		};

		if (ethsw->vlans[vid]) {
		dev_err(ethsw->dev, "VLAN already configured\n");
		return -EEXIST;
		}

		err = dpsw_vlan_add(ethsw->mc_io, 0,
		ethsw->dpsw_handle, vid, &vcfg);
		if (err) {