Commit 36ec62b7 authored Aug 13, 2019 by Ioana Ciornei Committed by Greg Kroah-Hartman Aug 14, 2019

staging: fsl-dpaa2/ethsw: remove unnecessary memset



The ethtool core already zeroes the memory before calling
.get_ethtool_stats() thus making the memset unnecessary. Remove it.

Reported-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Link: https://lore.kernel.org/r/1565700187-16048-7-git-send-email-ioana.ciornei@nxp.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 38ec70cc

drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -149,9 +149,6 @@ static void ethsw_ethtool_get_stats(struct net_device *netdev,
		struct ethsw_port_priv *port_priv = netdev_priv(netdev);
		int i, err;

		memset(data, 0,
		sizeof(u64) * ETHSW_NUM_COUNTERS);

		for (i = 0; i < ETHSW_NUM_COUNTERS; i++) {
		err = dpsw_if_get_counter(port_priv->ethsw_data->mc_io, 0,
		port_priv->ethsw_data->dpsw_handle,

Admin message