Commit e0d57d9c authored Aug 02, 2019 by Maxim Mikityanskiy Committed by Saeed Mahameed Aug 15, 2019

net/mlx5e: Fix a race with XSKICOSQ in XSK wakeup flow



Add a missing spinlock around XSKICOSQ usage at the activation stage,
because there is a race between a configuration change and the
application calling sendto().

Fixes: db05815b ("net/mlx5e: Add XSK zero-copy support")
Signed-off-by: Maxim Mikityanskiy <maximmi@mellanox.com>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>

parent 2aafdf5a

drivers/net/ethernet/mellanox/mlx5/core/en/xsk/setup.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -143,7 +143,10 @@ void mlx5e_activate_xsk(struct mlx5e_channel *c)
		{
		set_bit(MLX5E_RQ_STATE_ENABLED, &c->xskrq.state);
		/* TX queue is created active. */

		spin_lock(&c->xskicosq_lock);
		mlx5e_trigger_irq(&c->xskicosq);
		spin_unlock(&c->xskicosq_lock);
		}

		void mlx5e_deactivate_xsk(struct mlx5e_channel *c)

Admin message