Commit 2aafdf5a authored Aug 15, 2019 by Anders Roxell Committed by David S. Miller Aug 15, 2019

selftests: net: tcp_fastopen_backup_key.sh: fix shellcheck issue



When running tcp_fastopen_backup_key.sh the following issue was seen in
a busybox environment.
./tcp_fastopen_backup_key.sh: line 33: [: -ne: unary operator expected

Shellcheck showed the following issue.
$ shellcheck tools/testing/selftests/net/tcp_fastopen_backup_key.sh

In tools/testing/selftests/net/tcp_fastopen_backup_key.sh line 33:
        if [ $val -ne 0 ]; then
             ^-- SC2086: Double quote to prevent globbing and word splitting.

Rework to do a string comparison instead.

Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent c554336e

tools/testing/selftests/net/tcp_fastopen_backup_key.sh

+1 −1

Original line number	Diff line number	Diff line
		@@ -30,7 +30,7 @@ do_test() {
		ip netns exec "${NETNS}" ./tcp_fastopen_backup_key "$1"
		val=$(ip netns exec "${NETNS}" nstat -az \| \
		grep TcpExtTCPFastOpenPassiveFail \| awk '{print $2}')
		if [ $val -ne 0 ]; then
		if [ "$val" != 0 ]; then
		echo "FAIL: TcpExtTCPFastOpenPassiveFail non-zero"
		return 1
		fi

Admin message