Commit deb9c462 authored Aug 24, 2019 by Uwe Kleine-König Committed by Thierry Reding Sep 21, 2019

pwm: sun4i: Don't update the state for the caller of pwm_apply_state()



The pwm-sun4i driver is one of only three PWM drivers which updates the
state for the caller of pwm_apply_state(). This might have surprising
results if the caller reuses the values expecting them to still
represent the same state.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>

parent 797a5ebc

drivers/pwm/pwm-sun4i.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -192,12 +192,6 @@ static int sun4i_pwm_calculate(struct sun4i_pwm_chip *sun4i_pwm,
		*dty = div;
		*prsclr = prescaler;

		div = (u64)pval * NSEC_PER_SEC * *prd;
		state->period = DIV_ROUND_CLOSEST_ULL(div, clk_rate);

		div = (u64)pval * NSEC_PER_SEC * *dty;
		state->duty_cycle = DIV_ROUND_CLOSEST_ULL(div, clk_rate);

		return 0;
		}

Admin message