Commit 797a5ebc authored Aug 24, 2019 by Uwe Kleine-König Committed by Thierry Reding Sep 21, 2019

pwm: rockchip: Don't update the state for the caller of pwm_apply_state()



The pwm-rockchip driver is one of only three PWM drivers which updates
the state for the caller of pwm_apply_state(). This might have
surprising results if the caller reuses the values expecting them to
still represent the same state.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>

parent 01ccf903

drivers/pwm/pwm-rockchip.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -212,12 +212,6 @@ static int rockchip_pwm_apply(struct pwm_chip chip, struct pwm_device pwm,
		goto out;
		}

		/*
		* Update the state with the real hardware, which can differ a bit
		* because of period/duty_cycle approximation.
		*/
		rockchip_pwm_get_state(chip, pwm, state);

		out:
		clk_disable(pc->pclk);

Admin message