Commit de37e273 authored by Dmytro Laktyushkin's avatar Dmytro Laktyushkin Committed by Alex Deucher
Browse files

drm/amd/display: fix memory leak

parent d4e745e3
Loading
Loading
Loading
Loading
+12 −14
Original line number Diff line number Diff line
@@ -918,7 +918,6 @@ bool dc_post_update_surfaces_to_stream(struct dc *dc)
	int i;
	struct core_dc *core_dc = DC_TO_CORE(dc);
	struct validate_context *context = dm_alloc(sizeof(struct validate_context));
	bool result = true;

	if (!context) {
		dm_error("%s: failed to create validate ctx\n", __func__);
@@ -927,28 +926,29 @@ bool dc_post_update_surfaces_to_stream(struct dc *dc)
	dc_resource_validate_ctx_copy_construct(core_dc->current_context, context);

	post_surface_trace(dc);

	for (i = 0; i < context->res_ctx.pool->pipe_count; i++)
		if (context->res_ctx.pipe_ctx[i].stream == NULL) {
			context->res_ctx.pipe_ctx[i].pipe_idx = i;
			core_dc->hwss.power_down_front_end(
					core_dc, &context->res_ctx.pipe_ctx[i]);
		}

	if (!core_dc->res_pool->funcs->validate_bandwidth(core_dc, context)) {
		BREAK_TO_DEBUGGER();
		result = false;
		goto cleanup;
		dc_resource_validate_ctx_destruct(context);
		dm_free(context);
		return false;
	}

	core_dc->hwss.set_bandwidth(core_dc, context, true);

	dc_resource_validate_ctx_copy_construct(context, core_dc->current_context);

cleanup:
	dc_resource_validate_ctx_destruct(context);
	dm_free(context);
	if (core_dc->current_context) {
		dc_resource_validate_ctx_destruct(core_dc->current_context);
		dm_free(core_dc->current_context);
	}
	core_dc->current_context = context;

	return result;
	return true;
}

bool dc_commit_surfaces_to_stream(
@@ -1440,11 +1440,9 @@ void dc_update_surfaces_and_stream(struct dc *dc,
	return;

fail:
	if (core_dc->current_context != context) {
	dc_resource_validate_ctx_destruct(context);
	dm_free(context);
}
}

uint8_t dc_get_current_stream_count(const struct dc *dc)
{