Commit dd838821 authored Mar 06, 2019 by Yihao Wu Committed by J. Bruce Fields Mar 06, 2019

nfsd: fix wrong check in write_v4_end_grace()



Commit 62a063b8 "nfsd4: fix crash on writing v4_end_grace before
nfsd startup" is trying to fix a NULL dereference issue, but it
mistakenly checks if the nfsd server is started. So fix it.

Fixes: 62a063b8 "nfsd4: fix crash on writing v4_end_grace before nfsd startup"
Cc: stable@vger.kernel.org
Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
Signed-off-by: Yihao Wu <wuyihao@linux.alibaba.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

parent b602345d

fs/nfsd/nfsctl.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1126,7 +1126,7 @@ static ssize_t write_v4_end_grace(struct file file, char buf, size_t size)
		case 'Y':
		case 'y':
		case '1':
		if (nn->nfsd_serv)
		if (!nn->nfsd_serv)
		return -EBUSY;
		nfsd4_end_grace(nn);
		break;

Admin message