Commit 62a063b8 authored Nov 27, 2018 by J. Bruce Fields

nfsd4: fix crash on writing v4_end_grace before nfsd startup



Anatoly Trosinenko reports that this:

1) Checkout fresh master Linux branch (tested with commit e195ca6c)
2) Copy x84_64-config-4.14 to .config, then enable NFS server v4 and build
3) From `kvm-xfstests shell`:

results in NULL dereference in locks_end_grace.

Check that nfsd has been started before trying to end the grace period.

Reported-by: Anatoly Trosinenko <anatoly.trosinenko@gmail.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

parent b8db1592

fs/nfsd/nfsctl.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1126,6 +1126,8 @@ static ssize_t write_v4_end_grace(struct file file, char buf, size_t size)
		case 'Y':
		case 'y':
		case '1':
		if (nn->nfsd_serv)
		return -EBUSY;
		nfsd4_end_grace(nn);
		break;
		default:

Admin message