Commit dc475ae9 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Luca Coelho
Browse files

iwlwifi: iwl-drv: no need to check return value of debugfs_create functions 



When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Johannes Berg <johannes.berg@intel.com>
Cc: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: Luca Coelho <luciano.coelho@intel.com>
Cc: Intel Linux Wireless <linuxwifi@intel.com>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
parent 5987dfde

drivers/net/wireless/intel/iwlwifi/iwl-drv.c

+0 −22
Original line number Diff line number Diff line
@@ -1253,11 +1253,6 @@ _iwl_op_mode_start(struct iwl_drv *drv, struct iwlwifi_opmode_table *op) 
#ifdef CONFIG_IWLWIFI_DEBUGFS

	drv->dbgfs_op_mode = debugfs_create_dir(op->name,

						drv->dbgfs_drv);

	if (!drv->dbgfs_op_mode) {

		IWL_ERR(drv,

			"failed to create opmode debugfs directory\n");

		return op_mode;

	}

	dbgfs_dir = drv->dbgfs_op_mode;

#endif
@@ -1620,20 +1615,8 @@ struct iwl_drv *iwl_drv_start(struct iwl_trans *trans) 
	drv->dbgfs_drv = debugfs_create_dir(dev_name(trans->dev),

					    iwl_dbgfs_root);



	if (!drv->dbgfs_drv) {

		IWL_ERR(drv, "failed to create debugfs directory\n");

		ret = -ENOMEM;

		goto err_free_tlv;

	}



	/* Create transport layer debugfs dir */

	drv->trans->dbgfs_dir = debugfs_create_dir("trans", drv->dbgfs_drv);



	if (!drv->trans->dbgfs_dir) {

		IWL_ERR(drv, "failed to create transport debugfs directory\n");

		ret = -ENOMEM;

		goto err_free_dbgfs;

	}

#endif



	ret = iwl_request_firmware(drv, true);
@@ -1646,9 +1629,7 @@ struct iwl_drv *iwl_drv_start(struct iwl_trans *trans) 


err_fw:

#ifdef CONFIG_IWLWIFI_DEBUGFS

err_free_dbgfs:

	debugfs_remove_recursive(drv->dbgfs_drv);

err_free_tlv:

	iwl_fw_dbg_free(drv->trans);

#endif

	kfree(drv);
@@ -1759,9 +1740,6 @@ static int __init iwl_drv_init(void) 
#ifdef CONFIG_IWLWIFI_DEBUGFS

	/* Create the root of iwlwifi debugfs subsystem. */

	iwl_dbgfs_root = debugfs_create_dir(DRV_NAME, NULL);



	if (!iwl_dbgfs_root)

		return -EFAULT;

#endif



	return iwl_pci_register_driver();

CRA Git | Maintained and supported by SUSTech CRA and CCSE